FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » RC5: goto links
Show: Today's Messages :: Polls :: Message Navigator
Switch to threaded view of this topic Create a new topic Submit Reply
RC5: goto links [message #10821] Tue, 10 June 2003 22:39 Go to next message
tgaastra is currently offline  tgaastra   United States
Messages: 90
Registered: June 2002
Karma: 0
Member
The ?t=rview&goto=#### type links are taking people to the front page of the forums (the forum category view) rather than the message. Is this expected behaviour now?
Re: RC5: goto links [message #10822 is a reply to message #10821] Tue, 10 June 2003 22:41 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
No, that would be a bug. Although it seems to work perfectly fine on this forum.

FUDforum Core Developer
Re: RC5: goto links [message #10823 is a reply to message #10822] Tue, 10 June 2003 22:56 Go to previous messageGo to next message
tgaastra is currently offline  tgaastra   United States
Messages: 90
Registered: June 2002
Karma: 0
Member
Yep, they do here... but definitely not on my forums... So its not a browser issue I guess.... must be server related somehow, although I'm not sure how.
Re: RC5: goto links [message #10824 is a reply to message #10823] Tue, 10 June 2003 23:23 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Are you using a custom theme?

FUDforum Core Developer
Re: RC5: goto links [message #10825 is a reply to message #10824] Tue, 10 June 2003 23:32 Go to previous messageGo to next message
tgaastra is currently offline  tgaastra   United States
Messages: 90
Registered: June 2002
Karma: 0
Member
A modified default (edits to the forums.css, usercp, and post_common)
Re: RC5: goto links [message #10826 is a reply to message #10825] Tue, 10 June 2003 23:43 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Hmm.. should be ok.

Did it begin not working after the RC5 upgrade and if so from which version were you upgrading from?


FUDforum Core Developer

[Updated on: Tue, 10 June 2003 23:43]

Report message to a moderator

Re: RC5: goto links [message #10827 is a reply to message #10826] Wed, 11 June 2003 00:02 Go to previous messageGo to next message
tgaastra is currently offline  tgaastra   United States
Messages: 90
Registered: June 2002
Karma: 0
Member
This was a complete reinstall of 2.5.0RC4 (with the old MySQL database reimported in "mysql < dumpfile", the messages directory copied in, the files directory copied in) upgraded to RC5...

Just created a completely seperate RC4 test forum, and got the same behavior... I'm going to try it here in a second with a pure RC5 test install....
Re: RC5: goto links [message #10828 is a reply to message #10827] Wed, 11 June 2003 00:05 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
You may have ended with outdated sources, which is what is causing the problem. If clean RC5 install does not have the problem try overwriting files in your src/ directory with the ones from the clean RC5 install.

FUDforum Core Developer
Re: RC5: goto links [message #10829 is a reply to message #10828] Wed, 11 June 2003 00:09 Go to previous messageGo to next message
tgaastra is currently offline  tgaastra   United States
Messages: 90
Registered: June 2002
Karma: 0
Member
RC5 clean install has exact same behavior.
Re: RC5: goto links [message #10831 is a reply to message #10821] Wed, 11 June 2003 03:21 Go to previous messageGo to next message
Xodnizel   United States
Messages: 73
Registered: May 2003
Karma: 0
Member
It's looking for rview.php from the compiled themes directory, and not finding it, it displays the main index page.

Here's a diff, for root_index.php, that fixes the problem for me. Just flip around those if/else if statements.

97,100c97
< if (!isset($t) || preg_match('/[^A-Za-z0-9_]/', $t) || !@file_exists($WWW_ROOT_DISK . fud_theme . $t . '.php')) {
< $t = 'index';
< }
< else if ($t == 'rview') {
---
> if ($t == 'rview') {
108a106,109
> else if (!isset($t) || preg_match('/[^A-Za-z0-9_]/', $t) || !@file_exists($WWW_ROOT_DISK . fud_theme . $t . '.php')) {
> $t = 'index';
> }
>

[Updated on: Wed, 11 June 2003 03:28]

Report message to a moderator

Re: RC5: goto links [message #10832 is a reply to message #10831] Wed, 11 June 2003 03:36 Go to previous messageGo to next message
tgaastra is currently offline  tgaastra   United States
Messages: 90
Registered: June 2002
Karma: 0
Member
If that's the case, it stands to reason, because there is no rview.php anywhere.... Nor is there any such files in a checkout of the CVS source...

But my read of the index.php code seems to say there's a special case for the rview t setting which eventually sets it to look for msg.php (in my case, since tree viewing is disabled)

Ah wait, I see the problem...

Yeah, its the file_exists call that's the problem...

[Updated on: Wed, 11 June 2003 03:38]

Report message to a moderator

Re: RC5: goto links [message #10833 is a reply to message #10832] Wed, 11 June 2003 03:48 Go to previous messageGo to next message
tgaastra is currently offline  tgaastra   United States
Messages: 90
Registered: June 2002
Karma: 0
Member
Yep, as a cheap hack, I can touch an empty file in the theme directory named rview.php, and everything works.
Re: RC5: goto links [message #10834 is a reply to message #10833] Wed, 11 June 2003 04:19 Go to previous message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Fixed in CVS.

FUDforum Core Developer
  Switch to threaded view of this topic Create a new topic Submit Reply
Previous Topic: 2.5.0RC3 basic mode RDF not validating as RSS...
Next Topic: What's wrong ?
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sat Nov 23 15:46:26 GMT 2024

Total time taken to generate the page: 0.02336 seconds