RC5: goto links [message #10821] |
Tue, 10 June 2003 22:39 |
tgaastra
Messages: 90 Registered: June 2002
Karma: 0
|
Member |
|
|
The ?t=rview&goto=#### type links are taking people to the front page of the forums (the forum category view) rather than the message. Is this expected behaviour now?
|
|
|
Re: RC5: goto links [message #10822 is a reply to message #10821] |
Tue, 10 June 2003 22:41 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
No, that would be a bug. Although it seems to work perfectly fine on this forum.
FUDforum Core Developer
|
|
|
|
|
|
|
|
Re: RC5: goto links [message #10828 is a reply to message #10827] |
Wed, 11 June 2003 00:05 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
You may have ended with outdated sources, which is what is causing the problem. If clean RC5 install does not have the problem try overwriting files in your src/ directory with the ones from the clean RC5 install.
FUDforum Core Developer
|
|
|
|
Re: RC5: goto links [message #10831 is a reply to message #10821] |
Wed, 11 June 2003 03:21 |
|
Xodnizel
Messages: 73 Registered: May 2003
Karma: 0
|
Member |
|
|
It's looking for rview.php from the compiled themes directory, and not finding it, it displays the main index page.
Here's a diff, for root_index.php, that fixes the problem for me. Just flip around those if/else if statements.
97,100c97
< if (!isset($t) || preg_match('/[^A-Za-z0-9_]/', $t) || !@file_exists($WWW_ROOT_DISK . fud_theme . $t . '.php')) {
< $t = 'index';
< }
< else if ($t == 'rview') {
---
> if ($t == 'rview') {
108a106,109
> else if (!isset($t) || preg_match('/[^A-Za-z0-9_]/', $t) || !@file_exists($WWW_ROOT_DISK . fud_theme . $t . '.php')) {
> $t = 'index';
> }
>
[Updated on: Wed, 11 June 2003 03:28] Report message to a moderator
|
|
|
Re: RC5: goto links [message #10832 is a reply to message #10831] |
Wed, 11 June 2003 03:36 |
tgaastra
Messages: 90 Registered: June 2002
Karma: 0
|
Member |
|
|
If that's the case, it stands to reason, because there is no rview.php anywhere.... Nor is there any such files in a checkout of the CVS source...
But my read of the index.php code seems to say there's a special case for the rview t setting which eventually sets it to look for msg.php (in my case, since tree viewing is disabled)
Ah wait, I see the problem...
Yeah, its the file_exists call that's the problem...
[Updated on: Wed, 11 June 2003 03:38] Report message to a moderator
|
|
|
|
|