FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » FUDforum 3.0+ » hardcoded colors
Show: Today's Messages :: Polls :: Message Navigator
Switch to threaded view of this topic Create a new topic Submit Reply
hardcoded colors [message #13801] Mon, 27 October 2003 22:22 Go to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member

som colors is still hardcoded in the template, like bgcolor="#dee2e6" etc...
Re: hardcoded colors [message #13802 is a reply to message #13801] Mon, 27 October 2003 22:23 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Which template?

FUDforum Core Developer
Re: hardcoded colors [message #13804 is a reply to message #13801] Mon, 27 October 2003 22:45 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member

ok, here is what I found:
[azatoth@h55x311 tmpl]$ grep --exclude=*.css.* -no -E '\#[0-9A-Fa-f]{6}' *
avatarsel.tmpl:19:#f4f4f4
avatarsel.tmpl:23:#f4f4f4
#fefefe
coppa_fax.tmpl:19:#ffffff
curtime.tmpl:13:#000000
drawpmsg.tmpl:167:#FFFFFF
groupmgr.tmpl:99:#FF0000
groupmgr.tmpl:103:#0000FF
groupmgr.tmpl:138:#00AA00
groupmgr.tmpl:142:#00AA00
groupmgr.tmpl:239:#FF0000
groupmgr.tmpl:243:#0000FF
ignore_list.tmpl:43:#00AA00
minimsg.tmpl:22:#efefef
mnav.tmpl:131:#eeeeee
mnav.tmpl:136:#dee2e6
mvthread.tmpl:31:#e5ffe7
pmsg.tmpl:149:#FFFFFF
#c2cdd6
pmsg.tmpl:165:#FFFFFF
pmsg.tmpl:169:#fffa00
pmsg.tmpl:173:#FF0000
pmuserloc.tmpl:41:#efefef
reg_conf.tmpl:38:#ff0000
rpasswd.tmpl:33:#ffffff
tabs.tmpl:16:#dee2e6
tabs.tmpl:22:#c2cdd6
tabs.tmpl:29:#dee2e6
tabs.tmpl:31:#dee2e6
tabs.tmpl:32:#dee2e6
tabs.tmpl:34:#dee2e6
tabs.tmpl:39:#dee2e6
tabs.tmpl:40:#000000
Re: hardcoded colors [message #13805 is a reply to message #13801] Mon, 27 October 2003 23:05 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member

I don't want to edit the other tmpl-files this time, other than the css, so for now I'll do like this, (a bit ugly but... Smile)

*[bgcolor='#eeeeee'] {
    background: #232334;
}

*[bgcolor='#dee2e6'] {
    background: #323243;
}
Re: hardcoded colors [message #13806 is a reply to message #13801] Mon, 27 October 2003 23:51 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member

ok, I had to make one change, that is in pmsg.tmpl:

149c149
< <table width="175" cellspacing="1" cellpadding="2" border="0" style="background-color: #FFFFFF; border: 1px #c2cdd6 solid;">
---
> <table class="pmsgUsage" width="175" cellspacing="1" cellpadding="2" border="0">
165c165
< <td bgcolor="#FFFFFF"><img src="blank.gif" alt="" width={VAR: full_indicator} height="8" /></td>
---
> <td><img src="{THEME_IMAGE_ROOT}/indicator_normal.png" alt="normal" width={VAR: full_indicator} height="10" /></td>
169c169
< <td bgcolor="#fffa00"><img src="blank.gif" alt="" width={VAR: full_indicator} height="8" /></td>
---
> <td><img src="{THEME_IMAGE_ROOT}/indicator_alert.png" alt="alert" width={VAR: full_indicator} height="10" /></td>
173c173
< <td bgcolor="#FF0000"><img src="blank.gif" alt="" width={VAR: full_indicator} height="8" /></td>
---
> <td><img src="{THEME_IMAGE_ROOT}/indicator_full.png" alt="full" width={VAR: full_indicator} height="10" /></td>
Re: hardcoded colors [message #13810 is a reply to message #13806] Tue, 28 October 2003 03:10 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Fixed in CVS.

FUDforum Core Developer
Re: hardcoded colors [message #13812 is a reply to message #13801] Tue, 28 October 2003 03:41 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member

ok, when you are cleaning up, perhaps the styles in the tmpl-files is to be removed also?

avatarsel.tmpl:23:style="{ALT-VAR: avatarsel_cl #f4f4f4 #fefefe}"
groupmgr.tmpl:231:style="font-size: x-small"
reg_conf.tmpl:38:style="border: 1px dashed #ff0000"
register.tmpl:421:style="font-size: xx-small; color: 005500;"
report.tmpl:27:style="padding: 5px; padding-left: 20px;"
selmsg.tmpl:27:style="font-size: xx-small; font-weight: bold; text-decoration: none;"
selmsg.tmpl:31:style="font-size: xx-small; font-weight: bold; text-decoration: none;"
selmsg.tmpl:59:style="font-size: 12px;"
tabs.tmpl:15:style="background-image: url({THEME_IMAGE_ROOT}/tab_start.png);"
tabs.tmpl:16:style="background-image: url({THEME_IMAGE_ROOT}/tab_top.png);"
tabs.tmpl:17:style="background-image: url({THEME_IMAGE_ROOT}/tab_end.png);"
tabs.tmpl:21:style="background-image: url({THEME_IMAGE_ROOT}/tab_start.png);"
tabs.tmpl:22:style="background-image: url({THEME_IMAGE_ROOT}/tab_top.png);"
tabs.tmpl:23:style="background-image: url({THEME_IMAGE_ROOT}/tab_end.png);"
thread.tmpl:126:style="margin-top: 2px; margin-bottom: 2px;"
threadt.tmpl:59:style="padding-left: {VAR: width}px"
threadt.tmpl:79:style="padding-left: {VAR: width}px"
tree.tmpl:164:style="padding-left: {VAR: width}px"
tree.tmpl:177:style="padding-left: {VAR: width}px"
tree.tmpl:189:style="padding-left: {VAR: width}px"
tree.tmpl:201:style="padding-left: {VAR: width}px"
ulink.tmpl:15:style="color: {VAR: custom_color}"
usercp.tmpl:31:style="margin-bottom: 5px"
Re: hardcoded colors [message #13815 is a reply to message #13801] Tue, 28 October 2003 07:18 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member

Perhaps I'm ugly now, but maybe editing also:
register.tmpl:425:color="red" size="+2">{MSG: register_err_time_limit}</font></td></tr>
selmsg.tmpl:27:color="red">{MSG: on}</font>)</font>

[Updated on: Tue, 28 October 2003 07:21]

Report message to a moderator

Re: hardcoded colors [message #13819 is a reply to message #13812] Tue, 28 October 2003 15:25 Go to previous message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
The images in the tabs are gone, I reworked the tab drawing code to avoid them.
Tree style cannot be removed, it's dynamic padding, meaning that it cannot be inside a static .css file. Same applies to threat.tmpl & ulink.tmpl.

The remainder I have just fixed.


FUDforum Core Developer
  Switch to threaded view of this topic Create a new topic Submit Reply
Previous Topic: New in 2.6.0RC1
Next Topic: I have change the amount of Topic from 40 to 25
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Tue Nov 05 09:13:34 GMT 2024

Total time taken to generate the page: 0.02397 seconds