FUDforum: comp.lang.php » database access

Home » Imported messages » comp.lang.php » database access

Show: Today's Messages :: Polls :: Message Navigator

Re: database access [message #174196 is a reply to message #174194]

Thu, 26 May 2011 13:00

Jerry Stuckle
Messages: 2598
Registered: September 2010

Karma:

Senior Member

On 5/26/2011 8:09 AM, sheldonlg wrote:
> On 5/25/2011 5:37 PM, Jerry Stuckle wrote:
>> On 5/25/2011 1:17 PM, Jivanmukta wrote:
>>> I new relatively new to PHP. I need your opinion if the following set
>>> of database functions make sense:
>>>
>>> function openDatabase() {
>>> global $db;
>>> try {
>>> $db = new PDO('mysql:host=' . MYSQL_SERVER . ';dbname=' .
>>> MYSQL_DATABASE, MYSQL_USER, MYSQL_PASSWORD);
>>> $db->exec('SET NAMES latin2');
>>> $db->exec('SET CHARACTER SET latin2 COLLATE latin2_general_ci');
>>> $db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
>>> register_shutdown_function('closeDatabase');
>>> } catch (PDOException $e) {
>>> return false;
>>> }
>>> return true;
>>> }
>>>
>>> function closeDatabase() {
>>> global $db, $inTransaction;
>>> if ($inTransaction) {
>>> $db->rollBack();
>>> $inTransaction = false;
>>> }
>>> if (!is_null($db)) {
>>> $db = null;
>>> }
>>> }
>>>
>>> function queryDatabase($sql) {
>>> global $db, $inTransaction;
>>> $result = array();
>>> try {
>>> $qry = $db->query($sql);
>>> if (!empty($qry)) {
>>> $result = $qry->fetchAll();
>>> }
>>> } catch (PDOException $e) {
>>> if ($inTransaction) {
>>> $db->rollBack();
>>> }
>>> error(ERRMSG_DATABASE_OPERATION_FAILED);
>>> }
>>> return $result;
>>> }
>>>
>>> function execDatabase($sql) {
>>> global $db, $inTransaction;
>>> $result = array();
>>> try {
>>> $result = $db->exec($sql);
>>> } catch (PDOException $e) {
>>> if ($inTransaction) {
>>> $db->rollBack();
>>> }
>>> error(ERRMSG_DATABASE_OPERATION_FAILED);
>>> }
>>> return $result;
>>> }
>>>
>>> function startTransaction() {
>>> global $db, $inTransaction;
>>> $db->beginTransaction();
>>> $inTransaction = true;
>>> }
>>>
>>> function commitTransaction() {
>>> global $db, $inTransaction;
>>> $inTransaction = false;
>>> if ($db->commit()) {
>>> return;
>>> }
>>> $db->rollBack();
>>> error(ERRMSG_DATABASE_OPERATION_FAILED);
>>> }
>>>
>>> function rollbackTransaction() {
>>> global $db, $inTransaction;
>>> $inTransaction = false;
>>> if ($db->rollBack()) {
>>> return;
>>> }
>>> error(ERRMSG_DATABASE_OPERATION_FAILED);
>>> }
>>>
>>> function lockTables($tables) {
>>> return execDatabase('LOCK TABLES ' . join(' WRITE, ', $tables) . '
>>> WRITE');
>>> }
>>>
>>> function unlockTables() {
>>> return execDatabase('UNLOCK TABLES');
>>> }
>>
>> Kind of, and maybe a bit overkill. But personally I'd put it all in a
>> Database class. The code would be more flexible and less prone to errors.
>>
>
> Further, I would not have globals. I would pass $db in via the
> constructor. Likewise, I would have $inTransaction be a class variable
> which gets set by the method startTransaction().
>

That was part of the class, Sheldon. In fact, I wouldn't even pass $db
into the constructor; it (along with $inTransaction, as you note) would
be class variables. That way the rest of the program is completely
independent of the database (and you can have more than one database
active concurrently if you want).

--
==================
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
jstucklex(at)attglobal(dot)net
==================

Report message to a moderator

[Message index]

		database access By: Jivanmukta on Wed, 25 May 2011 17:17
		Re: database access By: Jerry Stuckle on Wed, 25 May 2011 21:37
		Re: database access By: sheldonlg on Thu, 26 May 2011 12:09
		Re: database access By: Jerry Stuckle on Thu, 26 May 2011 13:00
		Re: database access By: sheldonlg on Thu, 26 May 2011 14:22
		Re: database access By: Jerry Stuckle on Thu, 26 May 2011 15:41
		Re: database access By: sheldonlg on Thu, 26 May 2011 16:07
		Re: database access By: sheldonlg on Thu, 26 May 2011 16:14
		Re: database access By: sophal chao on Sun, 29 May 2011 20:41
		Re: database access By: Jerry Stuckle on Mon, 30 May 2011 03:12
		Re: database access By: JohnT on Thu, 26 May 2011 13:05
		Re: database access By: Jivanmukta on Thu, 26 May 2011 13:37
		Re: database access By: sheldonlg on Thu, 26 May 2011 14:30
		Re: database access By: sheldonlg on Thu, 26 May 2011 14:33
		Re: database access By: Jerry Stuckle on Thu, 26 May 2011 15:43
		Re: database access By: Michael Fesser on Thu, 26 May 2011 17:48
		Re: database access By: Erwin Moller on Mon, 30 May 2011 08:56

Previous Topic:	Stats comp.lang.php (last 7 days)
Next Topic:	a more elegant way?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Nov 26 07:38:48 GMT 2024

Total time taken to generate the page: 0.11100 seconds