| Changing session variables gives warning [message #178960] |
Tue, 28 August 2012 06:37  |
jwcarlton
Messages: 76
Registered: December 2010
Karma: 0
|
Member |
|
|
I'm setting a series of SESSION variables, then on each page check to make sure one of those variables hasn't changed; if so, the script reloads them. The purpose is to limit the number of MySQL queries on an already taxed server.
I'm using a script like this:
if ($default != $_SESSION['default']) {
$var_query = sprintf("SELECT * FROM vars WHERE var='%s' LIMIT 1",
mysql_real_escape_string($default));
list($_SESSION['default'], ...) = mysql_fetch_row(mysql_query($var_query));
session_commit();
}
But now I get this warning in the log:
PHP Warning: session_commit() [<a href='function.session-commit'>function.session-commit</a>]: Your script possibly relies on a session side-effect which existed until PHP 4.2.3. Please be advised that the session extension does not consider global variables as a source of data, unless register_globals is enabled. You can disable this functionality and this warning by setting session.bug_compat_42 or session.bug_compat_warn to off, respectively in whatever.php on line 165
I'm using PHP 5.2.17.
Should I be changing these variables in a different way? Or is it perfectly safe to change the script to:
session_commit();
ini_set('session.bug_compat_warn', 0);
ini_set('session.bug_compat_42', 0);
|
|
|
|
| Re: Changing session variables gives warning [message #178972 is a reply to message #178960] |
Tue, 28 August 2012 15:42  |
J.O. Aho
Messages: 194
Registered: September 2010
Karma: 0
|
Senior Member |
|
|
On 28/08/12 08:37, Jason C wrote:
> I'm setting a series of SESSION variables, then on each page check to make sure one of those variables hasn't changed; if so, the script reloads them. The purpose is to limit the number of MySQL queries on an already taxed server.
>
> I'm using a script like this:
>
> if ($default != $_SESSION['default']) {
> $var_query = sprintf("SELECT * FROM vars WHERE var='%s' LIMIT 1",
> mysql_real_escape_string($default));
>
> list($_SESSION['default'], ...) = mysql_fetch_row(mysql_query($var_query));
why not just select the column you want instead of the whole row?
> session_commit();
drop this line
> }
>
> But now I get this warning in the log:
>
> PHP Warning: session_commit() [<a href='function.session-commit'>function.session-commit</a>]: Your script possibly relies on a session side-effect which existed until PHP 4.2.3. Please be advised that the session extension does not consider global variables as a source of data, unless register_globals is enabled. You can disable this functionality and this warning by setting session.bug_compat_42 or session.bug_compat_warn to off, respectively in whatever.php on line 165
>
> I'm using PHP 5.2.17.
>
> Should I be changing these variables in a different way? Or is it perfectly safe to change the script to:
I would suggest you skip using the session_write_close() (for which
session_commit is an alias for), as it won't do much at all for PHP5.
> session_commit();
> ini_set('session.bug_compat_warn', 0);
> ini_set('session.bug_compat_42', 0);
To make this to suppress the message in the error log, you need to run
the ini_set before the session_write_close(), but then it's simpler just
to drop it.
--
//Aho
|
|
|
|
Calendar
Search
Help
Members
Register
Login
Home
]