FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » japanese mail is broken.
Show: Today's Messages :: Polls :: Message Navigator
Switch to threaded view of this topic Create a new topic Submit Reply
japanese mail is broken. [message #23371] Mon, 14 March 2005 14:46 Go to next message
elf2000 is currently offline  elf2000   Japan
Messages: 22
Registered: July 2004
Location: Japan
Karma: 0
Junior Member
japanese mail is broken.
A reason is that there is no specification of content-type (charset).
correspondence can if a code is corrected as follows.


Index: iemail.inc.t
===================================================================
RCS file: /forum21/install/forum_data/src/iemail.inc.t,v
retrieving revision 1.37
diff -r1.37 iemail.inc.t
57a58
> $mail_func = function_exists( "mb_send_mail")? "mb_send_mail": "mail";
59c60
< mail($email, $subj, $body, $header);
---
> $mail_func($email, $subj, $body, $header);
Index: root_index.php.t
===================================================================
RCS file: /forum21/install/forum_data/src/root_index.php.t,v
retrieving revision 1.39
diff -r1.39 root_index.php.t
1a2,3
> mb_language( "ja");
> mb_internal_encoding( "UTF-8");


However, this correction place is not good.
I did not find the best place.
Thanks,


--
Tadashi Jokagi

Re: japanese mail is broken. [message #23374 is a reply to message #23371] Mon, 14 March 2005 15:43 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Fixed in CVS.

Here is the patch:
http://cvs.prohost.org/c/index.cgi/FUDforum/chngview?cn=3442


FUDforum Core Developer
Re: japanese mail is broken. [message #23386 is a reply to message #23374] Mon, 14 March 2005 22:36 Go to previous messageGo to next message
elf2000 is currently offline  elf2000   Japan
Messages: 22
Registered: July 2004
Location: Japan
Karma: 0
Junior Member
hum,
thanks!! Laughing

However, the fud_smtp class still remains.
Since I did not understand this completely yet, I was not able to write a patch. Razz

This can perform MIME encoding appropriately by using mb_encode_mimeheader().

http://php.net/mb_encode_mimeheader

Please add without forgetting the "Content-Type" header.


--
Tadashi Jokagi

Re: japanese mail is broken. [message #23405 is a reply to message #23386] Tue, 15 March 2005 16:39 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
The Content-Type header is already being sent there is no change needed for that. The subject of the message is also already being encoded. So, as far as I can tell no further changes are needed.

FUDforum Core Developer
Re: japanese mail is broken. [message #23412 is a reply to message #23371] Tue, 15 March 2005 17:57 Go to previous messageGo to next message
elf2000 is currently offline  elf2000   Japan
Messages: 22
Registered: July 2004
Location: Japan
Karma: 0
Junior Member
For example, there is admmassemail.php.
SMTP is processed from the 76th line.
This processing does not encode a header to the last.

I consider it better to perform encoding of a header in a fud_smtp class.



--
Tadashi Jokagi

Re: japanese mail is broken. [message #23424 is a reply to message #23412] Tue, 15 March 2005 22:11 Go to previous message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
I've added missing subject encoding...

FUDforum Core Developer
  Switch to threaded view of this topic Create a new topic Submit Reply
Previous Topic: "Move All Selected" and "Delete All Selected"
Next Topic: Minor typo in Moderator/User Manager.
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sun Nov 10 15:54:18 GMT 2024

Total time taken to generate the page: 0.02575 seconds