FUDforum: Bug Reports » Explanation of spoiler tag in the FAQ

Home » FUDforum Development » Bug Reports » Explanation of spoiler tag in the FAQ

Show: Today's Messages :: Polls :: Message Navigator

Explanation of spoiler tag in the FAQ [message #31155]

Wed, 05 April 2006 15:44

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

The sample of a spoiler tag in the FAQ doesn't work for me properly. When I open the FAQ page the spoiler is already opened but empty (the text "Hidden part of the message" is missing). Wouldn't it be better if the spoiler in FAQ worked as the spoiler in the forum?

I did an analysis of the source code:

normal message in the forum

<div class="dashed" style="padding: 3px;" align="center" width="100%"><a href="javascript://" OnClick="javascript: layerVis('535704201', 1);">Reveal Spoiler</a><div align="left" id="535704201" style="display: none;">Hidden part of the message</div></div>

FAQ

<div class="dashed" style="padding: 3px;" align="center" width="100%"><a href="javascript://" OnClick="javascript: layerVis('1482055279834293165', 1);">Reveal Spoiler</a><div align="left" id="1482055279834293165" style="visibility: hidden;">Hidden part of the message</div></div>

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31173 is a reply to message #31155]

Thu, 06 April 2006 02:52

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Thanks, fixed in CVS.

FUDforum Core Developer

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31181 is a reply to message #31155]

Thu, 06 April 2006 13:51

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

Now, it is working. Hopefully this will be fixed for the other languages too.

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31389 is a reply to message #31155]

Thu, 20 April 2006 09:53

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

There is another thing that I noticed:
Why does "Alignment" appears twice on FAQ index and what is the meaning of "Test Size" (that points to the "email" anchor)?

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31392 is a reply to message #31389]

Thu, 20 April 2006 13:29

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Fixed in CVS, the patch can be found here:
http://cvs.prohost.org/c/index.cgi/FUDforum/chngview?cn=7579

FUDforum Core Developer

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31450 is a reply to message #31155]

Mon, 24 April 2006 18:04

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

Looks better now. Smile

Now I want to make a suggestion, what do you think about arranging the FUDcode samples in two columns ("FUDcode syntax" and "Result") ? I think the current help page looks a bit complex.
The idea came to my mind as I saw the equivalent in the Invision Power Board (here is link to one).

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31461 is a reply to message #31450]

Wed, 26 April 2006 16:17

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Feel free to submit a patch Wink

FUDforum Core Developer

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31502 is a reply to message #31155]

Mon, 01 May 2006 15:59

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

Well I can try to make a patch. But due to my limited knowledge about HTML I don't think this would look well. Sad

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31987 is a reply to message #31461]

Mon, 29 May 2006 18:54

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

Ilia wrote on Wed, 26 April 2006 18:17

Feel free to submit a patch Wink

I attached my attempt, hopefully it is acceptable. Rolling Eyes

While trying to make this patch I noticed two other things:

The enumeration (section: How to format text?) on the help index isn't in the same order as the section in the help file. I think it would be clearer if it would be.
Internet Explorer doesn't show the • sign in the enumeration on help index. I think this doesn't look nice.

Attachment: readingposting.txt
(Size: 24.37KB, Downloaded 919 times)

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #31992 is a reply to message #31987]

Tue, 30 May 2006 02:56

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Your description of the FUDcode tags was put into the CVS and the IE bug was resolved.

FUDforum Core Developer

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #32002 is a reply to message #31155]

Tue, 30 May 2006 16:19

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

Great, I'm very sory but I overlooked a small bug concering the anchor for url hyperlinking.

Attached file should fix it (and some small typos).

By the way I will make a german translation as soon as possible.

Attachment: readingposting.txt
(Size: 24.37KB, Downloaded 1000 times)

[Updated on: Tue, 30 May 2006 16:23]

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #32008 is a reply to message #32002]

Tue, 30 May 2006 23:41

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Fixed, thanks for the update.

FUDforum Core Developer

Report message to a moderator

Re: Explanation of spoiler tag in the FAQ [message #32090 is a reply to message #31155]

Wed, 07 June 2006 20:39

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma: 0

Senior Member
Contributing Core Developer
Translator

I updated the german translation, it should be up to date with the latest cvs version.

And I fixed some errors in english help file (the typos, that weren't in my last attachment + removed reference to ICQ notifacation)