FUDforum: Bug Reports » SQL bug in default theme

Home » FUDforum Development » Bug Reports » SQL bug in default theme

Show: Today's Messages :: Polls :: Message Navigator

SQL bug in default theme [message #34873]

Tue, 21 November 2006 15:49

jyoder

Messages: 5
Registered: November 2006
Location: Michigan, USA

Karma:

Junior Member

I stumbled across this bug in 2.7.6 when trying to register a new test user on my new forum. I've never used FUDforum before so this is a fresh install using Postgres as the database.

The SQL error was a bit cryptic, but it looks like the fix is pretty simple. Basically it looks like the parenthesis in the WHILE statement got a bit mixed up. I'm pretty confident my patch fixes both cases, but the COALESCE is what executes in my case so I couldn't test both.

What I did was remove the second closing parenthesis after the COALESCE (so the >0 applies to that and not the entire WHILE statement), added a second opening parenthesis before the (g1.group_cache_opt so that I could add a closing parenthesis after the >0. Okay, maybe I shouldn't have tried to explain it in english Smile

Here's a diff between the original index.php and my patched one:

diff -ru ./forum.orig/theme/default/index.php ./forum/theme/default/index.php
--- ./forum.orig/theme/default/index.php   2006-11-21 08:26:40.000000000 -0700
+++ ./forum/theme/default/index.php    2006-11-21 08:22:43.000000000 -0700
@@ -147,7 +147,7 @@
                        ((!$is_a || $cat_id) ?  ' WHERE ' : '') .
-                       ($is_a ? '' : (_uid ? ' (mo.id IS NOT NULL OR (COALESCE(g2.group_cache_opt, g1.group_cache_opt))' : ' (g1.group_cache_opt').' & 1)>0') .
+                       ($is_a ? '' : (_uid ? ' (mo.id IS NOT NULL OR (COALESCE(g2.group_cache_opt, g1.group_cache_opt)' : ' ((g1.group_cache_opt').' & 1)>0)') .
                        ($cat_id ? ($is_a ? '' : ' AND ') . ' v.c IN('.implode(',', ($cf = $cidxc[$cat_id][5])).') ' : '').' ORDER BY v.id');

Report message to a moderator

[Message index]

		SQL bug in default theme By: jyoder on Tue, 21 November 2006 15:49
		Re: SQL bug in default theme By: Ernesto on Tue, 21 November 2006 16:39
		Re: SQL bug in default theme By: jyoder on Tue, 21 November 2006 17:31
		Re: SQL bug in default theme By: Ilia on Wed, 22 November 2006 15:12
		Re: SQL bug in default theme By: jyoder on Wed, 22 November 2006 16:44
		Re: SQL bug in default theme By: Ilia on Thu, 23 November 2006 14:27
		Re: SQL bug in default theme By: jyoder on Fri, 01 December 2006 03:50
		Re: SQL bug in default theme By: Ilia on Fri, 01 December 2006 15:39
		Re: SQL bug in default theme By: jyoder on Fri, 01 December 2006 16:45
		Re: SQL bug in default theme By: hoanhnd on Wed, 06 December 2006 08:49
		Re: SQL bug in default theme By: hoanhnd on Wed, 06 December 2006 08:39

Previous Topic:	problems with CSS after changing document root for FUDforum
Next Topic:	Inbox - Sort by xxxxxxx

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Wed Dec 04 19:41:26 GMT 2024

Total time taken to generate the page: 0.04033 seconds