|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Re: Moving single posts [message #33808 is a reply to message #33665] |
Fri, 22 September 2006 14:22 |
|
Ilia wrote on Tue, 12 September 2006 17:49 | Moving message from one topic to another is something to consider for 2.7.7.
|
Great! This is a very important feature for me.
|
|
|
|
|
|
|
|
|
|
|
Re: Moving single posts [message #35415 is a reply to message #35391] |
Tue, 09 January 2007 10:35 |
|
JanRei wrote on Sat, 06 January 2007 20:36 | First I would like to suggest that the topic hasn't be to selected by giving in the topic ID. I think that this makes it easy to make mistakes/typos and moving the messages to a wrong topic.
|
I have experience with such a method on our old handmade forum and I want to say, that's pretty comfortable. I've never had a mistakes. Moderator just have to be little attentive, that's all :)
|
|
|
|
|
|
|
Re: Moving single posts [message #35422 is a reply to message #35420] |
Tue, 09 January 2007 20:18 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
Ilia wrote on Tue, 09 Januar 2007 15:33 |
Both of the described issues are now fixed in CVS.
|
Great, I have applied the patch and it works indeed. But what's about the warning about in_array (now in line 409), can it be ignored?
When I want to move messages to a deleted topic, I get "You do not have the required permissions to perform this action". I was a little bit surprised since I was a admin at this time.
And the forum seems to have some problems with the message/topic counting:
When I move messages to a topic that is in another forum, the topic count on the index page doesn't seem to get updated.
When I move all messages of a topic to another I get a empty topic with "-1" replies (according to the topic listing).
[Updated on: Tue, 09 January 2007 20:18] Report message to a moderator
|
|
|
|
|
|
|
Re: Moving single posts [message #35456 is a reply to message #33608] |
Fri, 12 January 2007 16:02 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
Now I get some query errors:
Quote: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:415
C:\xampp\htdocs\forum\index.php:1194
) 1054: Unknown column 'last_post_date' in 'field list'
Query: UPDATE fud26_forum SET post_count=post_count+2, last_post_date=1168616130, last_post_id=3, last_post_id=3 WHERE id=2
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => 'e59c8cd9c612d21b06de0a0b8c198bed', 'SQ' => '0c321c58dbaca399f964cd14cb5effb2', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '3', ), )
Server Version: 5.0.21-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg
|
Quote: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:439
C:\xampp\htdocs\forum\index.php:1194
) 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '0) WHERE id=1' at line 1
Query: UPDATE fud26_forum SET post_count=MAX(post_count-1,0) WHERE id=1
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => 'e59c8cd9c612d21b06de0a0b8c198bed', 'SQ' => '6e29e03d399f6fd42cd892e474fec1a9', 'th' => '2', 'dest_th' => '1', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', ), )
Server Version: 5.0.21-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=2
|
|
|
|
|
Re: Moving single posts [message #35472 is a reply to message #33608] |
Sun, 14 January 2007 19:57 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
I still get the first query error:
Zitat: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:415
C:\xampp\htdocs\forum\index.php:1194
) 1054: Unknown column 'last_post_date' in 'field list'
Query: UPDATE fud26_forum SET post_count=post_count+2, last_post_date=1168798990, last_post_id=7, last_post_id=7 WHERE id=2
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => '69f262f1b06aee9a9f211da37f01ea37', 'SQ' => '244967d5871f0716cbb08ab06e37492a', 'th' => '3', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '6', 1 => '7', ), )
Server Version: 5.0.27-community
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=3
|
And this one seems to be new:
Zitat: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\index.php:135
C:\xampp\htdocs\forum\theme\default\movemsg.php:423
C:\xampp\htdocs\forum\index.php:1194
) 1146: Table 'fudforum.fud26__tv_1' doesn't exist
Query: SELECT t.last_post_id FROM fud26__tv_1 v INNER JOIN fud26_thread t ON t.id=v.thread_id WHERE tv_seq=1
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => '69f262f1b06aee9a9f211da37f01ea37', 'SQ' => '3a5da9b27ecf6ab5a254537b857f4135', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '2', ), )
Server Version: 5.0.27-community
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=1
|
|
|
|
|
|