FUDforum: Bug Reports » Topic syndication doesn't work

Home » FUDforum Development » Bug Reports » Topic syndication doesn't work

Show: Today's Messages :: Polls :: Message Navigator

Topic syndication doesn't work [message #40024]

Sat, 05 January 2008 13:30

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Syndication with mode=t doesn't work.

Example: http://fudforum.org/forum/rdf.php?mode=t&l=1&basic=1&frm=1& n=25

Report message to a moderator

Re: Topic syndication doesn't work [message #40033 is a reply to message #40024]

Sun, 06 January 2008 17:18

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

if you do "view source" the data is definitely there and there are entries corresponding to the topics in the forum.

FUDforum Core Developer

Report message to a moderator

Re: Topic syndication doesn't work [message #40035 is a reply to message #40033]

Sun, 06 January 2008 19:07

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

The thread feed is invalid.

Mode=m produces a valid RSS feed:
http://feedvalidator.org/check.cgi?url=http%3A%2F%2Ffudforum.org%2Fforum%2F rdf.php%3Fmode%3Dm%26l%3D1%26basic%3D1%26frm%3D1%26n%3D25

However, mode=t does not validate: http://feedvalidator.org/check.cgi?url=http%3A%2F%2Ffudforum.org%2Fforum%2F rdf.php%3Fmode%3Dt%26l%3D1%26basic%3D1%26frm%3D1%26n%3D25

Report message to a moderator

Re: Topic syndication doesn't work [message #40039 is a reply to message #40035]

Mon, 07 January 2008 21:33

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Fixed in CVS

FUDforum Core Developer

Report message to a moderator

Re: Topic syndication doesn't work [message #40041 is a reply to message #40039]

Tue, 08 January 2008 05:28

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Thanks Ilia! Can you please also apply this patch:

--- rdf.php.t.orig      2008-01-07 23:06:47.000000000 -0600
+++ rdf.php.t   2008-01-07 23:25:48.000000000 -0600
@@ -407,12 +407,12 @@
                                }

                                if ($basic) {
-                                       echo '<rdf:li rdf:resource="'.$WWW_ROOT.'index.php?t=rview&amp;th='.$r->thread_id.'" />';
+                                       echo '<rdf:li rdf:resource="'.$WWW_ROOT.'index.php?t=rview&amp;th='.$r->id.'" />';
                                        $data .= '
-<item rdf:about="'.$WWW_ROOT.'index.php?t=rview&amp;th='.$r->thread_id.'">
+<item rdf:about="'.$WWW_ROOT.'index.php?t=rview&amp;th='.$r->id.'">
        <title>'.htmlspecialchars($r->subject).'</title>
-       <link>'.$WWW_ROOT.'index.php?t=rview&amp;th='.$r->thread_id.'</link>
-       <description>'.sp($body).'</description>
+       <link>'.$WWW_ROOT.'index.php?t=rview&amp;th='.$r->id.'</link>
+       <description>'.sp($r->tdescr).'</description>
        <dc:subject>'.sp($r->frm_name).'</dc:subject>
        <dc:creator>'.sp($r->alias).'</dc:creator>
        <dc:date>'.gmdate('Y-m-d\TH:i:s', $r->post_stamp).'-00:00</dc:date>

Report message to a moderator

Re: Topic syndication doesn't work [message #40054 is a reply to message #40041]

Tue, 08 January 2008 19:01

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

I am not sure topic description is a better option then a topic title, because the former may not always be present.

FUDforum Core Developer

Report message to a moderator

Re: Topic syndication doesn't work [message #40056 is a reply to message #40054]

Tue, 08 January 2008 19:23

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

I don't really care either way. I've changed $body to $r->tdescr because $body is not instantiated in the mode=t code. So, $body has always been empty. You are welcome to add it in though.

Report message to a moderator

Re: Topic syndication doesn't work [message #40067 is a reply to message #40056]

Thu, 10 January 2008 01:08

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

I've changed body to message subject now.

FUDforum Core Developer

Report message to a moderator

Re: Topic syndication doesn't work [message #40068 is a reply to message #40067]

Thu, 10 January 2008 04:57

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Great - thanks Ilia!

Report message to a moderator

Re: Topic syndication doesn't work [message #40070 is a reply to message #40068]

Thu, 10 January 2008 06:18

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Just some feedback: this doesn't look right - the title is repeated in the description (same info twice for each thread).

Please change the description to either the message body or $r->tdescr.

Report message to a moderator