| Re: GLOBALS.php "Bug"?? [message #165121 is a reply to message #165119] |
Thu, 28 April 2011 02:49   |
 |
Dayo
Messages: 101
Registered: April 2011
Karma:
|
Senior Member |
|
|
I get what you mean now.
Should work in most instances but not a suitable way to go about things. I'll have to go through the code called by FUDforum, find every one of the variables and declare them one by one. This is hellish and should not be neccessary at all.
I can see that in some places the variables are referenced directly, $XYZ, and in some others, using GLOBALS['XYZ\].
Now this is fair enough within the application but a more disciplined and structured approach is needed as while this may mean more work at times, it will make the application more extensible.
Define the stuff in GLOBALS.php as constants (not variables, global or otherwise) at the beginning of the flow and that's that. We know they are not going to change so why a variable in the first place anyway?
From then on, "CONF_XYZ" for instance, can be referred to anywhere without fear of tripping over anything. You don't, as a third party developer, have to wonder wherether you need to use this form or that form in this place or that place or whether ypou need to do anything special or not.
Will make things clean, structured and extensible.
So not quite a bug as such but more of a weakness in the design structure ... one which affects many other things in the application in general and one which puts obstacles in the way of third party devs.
I came to FUDforum because a feature I wanted, mailing lists, was not available elsewhere but have now realised that it would have been easier for me to try write a plugin to do this for phpBB3 due to having to have to overcome these structural issues in the main application here.
I'll suggest that a step back is needed for the next bigger point release to look at these issues. Basically a more "OOP" based approach is needed I think.
Anyway, just my 2 pence as an outsider trying to get a bit deeper into things.
|
|
|
|
Calendar
Search
Help
Members
Register
Login
Home
]