FUDforum: PHP discussions » Script problem

Home » General » PHP discussions » Script problem (Scritpt doesn't update database in email validation)

Show: Today's Messages :: Polls :: Message Navigator

Re: Script problem [message #165249 is a reply to message #165241]

Tue, 17 May 2011 03:01

Ernesto

Messages: 413
Registered: August 2005

Karma:

Senior Member

Now you are looping through you entire database until you find a match, it would make much mroe sense to not select anything at all.

First, you grab the $_GET, then you make sure it is clean.

$queryString = mysql_real_escape_string($_GET['code']);

(Read about SQL injections)

After that, you just
$sql = 'UPDATE membre SET status=1 WHERE activationkey = '.$queryString;

With your way you take ALL members from the database, loop though them in PHP until you find the match. That is not a good way, PHP is not made for looping that amount of data, however, that is JUST what an SQL server is made for, it can do it in a 100th of the time with a 100th of the effort. Imagine if you have a million users, it would take PHP days to loop it and it would take huge power to bring all the data from the database to the PHP layer.

Ginnunga Gaming

Report message to a moderator

[Message index]

		Script problem By: anemic-cinema on Fri, 13 May 2011 12:40
		Re: Script problem By: naudefj on Sat, 14 May 2011 12:43
		Re: Script problem By: anemic-cinema on Sat, 14 May 2011 13:07
		Re: Script problem By: naudefj on Sun, 15 May 2011 16:50
		Re: Script problem By: anemic-cinema on Sun, 15 May 2011 20:23
		Re: Script problem By: Ernesto on Tue, 17 May 2011 03:01
		Re: Script problem By: anemic-cinema on Tue, 17 May 2011 16:26

Previous Topic:	Usenet group import
Next Topic:	Choose PHP Framework Tips

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Nov 29 00:53:52 GMT 2024

Total time taken to generate the page: 0.04699 seconds