FUDforum: comp.lang.php » illegal offset problem

Home » Imported messages » comp.lang.php » illegal offset problem

Show: Today's Messages :: Polls :: Message Navigator

Re: illegal offset problem [message #184055 is a reply to message #184050]

Tue, 03 December 2013 23:46

Denis McMahon
Messages: 634
Registered: September 2010

Karma:

Senior Member

On Tue, 03 Dec 2013 17:25:49 -0500, richard wrote:

> foreach ($six0 as $itemkey => $item) {
> $song=$six0[$itemkey]['track'];
> echo "<div>$song</div>";};
>
> works fine. shows all songs for every year.
>
> }
>
> foreach ($six0 as $itemkey => $item) {
> $song=$six0[$itemkey]['track'];
> if ($year==$show){ echo "<div>$song</div>";}
> }
>
> Show nothing. Why?
>
> http://mroldies.net/test/menu4.html

I'm absolutely guessing on this one, but maybe in the second case $year
isn't equal to $show

Try dumping $show and $year

I suspect the code would be more efficient as:

if ($year==$show)
foreach ($six0 as $item)
echo "<div>{$item['track']}</div>";

1) Your code is checking $year against $show on every iteration of the
foreach loop, although neither of these variables is altered inside the
loop. Under these conditions, it makes more sense to do the comparison
outside the loop, and skip the whole loop if they don't match.

2) Having allocated the array data to $item, it is probably more
efficient to use it directly than to reference it as $six0[$itemkey],
which requires an array lookup.

I'm sure you will dismiss these points as pedantry, but pedantry such as
this equates to money in the real world of sizing server farms for the
server load.

Also, how many times do we have to point out to you that giving us links
to the output of the script doesn't really help us work out what you
screwed up.

--
Denis McMahon, denismfmcmahon(at)gmail(dot)com

Report message to a moderator

[Message index]

		illegal offset problem By: Mr Oldies on Tue, 03 December 2013 14:00
		Re: illegal offset problem By: Paul Herber on Tue, 03 December 2013 14:16
		Re: illegal offset problem By: Robert Heller on Tue, 03 December 2013 14:55
		Re: illegal offset problem By: Mr Oldies on Tue, 03 December 2013 15:04
		Re: illegal offset problem By: Mr Oldies on Tue, 03 December 2013 22:25
		Re: illegal offset problem By: Ben Bacarisse on Tue, 03 December 2013 23:06
		Re: illegal offset problem By: Robert Heller on Tue, 03 December 2013 23:16
		Re: illegal offset problem By: Denis McMahon on Tue, 03 December 2013 23:46
		Re: illegal offset problem By: Mr Oldies on Tue, 03 December 2013 22:39
		Re: illegal offset problem By: Denis McMahon on Tue, 03 December 2013 21:10
		Re: illegal offset problem By: Richard Yates on Wed, 04 December 2013 20:13

Previous Topic:	Can I download file with address like this "http://***.com/file.php/ABC.html" automatically ?
Next Topic:	request for error checking feature

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sun Nov 24 15:02:31 GMT 2024

Total time taken to generate the page: 0.04030 seconds