FUDforum: FUDforum Suggestions » virtual hosts support

Home » FUDforum » FUDforum Suggestions » virtual hosts support

Show: Today's Messages :: Polls :: Message Navigator

Re: virtual hosts support [message #28251 is a reply to message #28241]

Fri, 14 October 2005 16:10

ruzam

Messages: 44
Registered: July 2005

Karma:

Member

Hmmm... You have a knack for repeating code Wink

Ok, now I know you have an aversion virtual hosts support, but bare with me:

Take a close look at icons_adm.inc (skip over the virtual hosting specific bits) and admiconsel.php. These two (one new, one re-write) make for a single unified source of code to handle icons. Greatly simplifies the icon admin mamagement, and totally eliminates admavatarsel.php, admmimesel.php and admsmileyssel.php (or at least it could). I've patched admforum.php and admmime.php to use it so far. The mime patch looks pretty much exactly the same as it did before. The forum patch adds an icon upload section (as it shoud) to the forum editor. As it is in your existing code, you're doing the same thing over and over again. Sometimes the page says it will accept (.gif, *.jpg, *.jpeg, *.png), sometimes the page says it will accept (.gif, *.jpg, *.png), even though it does accept *.jpeg. That's what happens when you duplicate code Crying or Very Sad

I've eliminated the duplication. All Icons are treated equal, the interface is consitent to the user, the code is simplified. If a future icon type pops into existence, adding it to FUD will be a breaze. In fact, now the code can be tweaked to allow an external URL anywhere an icon can be displayed. That's some awesome flexibility.

BUT, forum icons work out of the box this way. MIME icons do not (and I suspect I'm going to find the same problem with smileys). I can probably fudge a whole bunch of code to maintain compatibility with existing FUD data, but that's going to create a future upgrade mess, or I could break with existing icon storage method, and start clean with a simple common image storage. I'm going to have to tweak the templates for MIME icons either way.

If you don't feel a unified icon management/presentation is a good thing, then I guess my only option is to branch and forget the backward compatibility. If you think common icon code is a good thing, then I'll keep hacking along with compatiblility in mind.

Attachment: icons_adm.inc
(Size: 6.79KB, Downloaded 1190 times)
Attachment: admiconsel.php
(Size: 1.08KB, Downloaded 1098 times)
Attachment: patch-admforum.php.txt
(Size: 8.29KB, Downloaded 1159 times)
Attachment: patch-admmime.php.txt
(Size: 8.11KB, Downloaded 1058 times)
Attachment: patch-forum_adm.inc.txt
(Size: 1.53KB, Downloaded 972 times)

Report message to a moderator

[Message index]

		virtual hosts support By: venus on Sat, 24 August 2002 12:10
		Re: virtual hosts support By: Ilia on Sat, 24 August 2002 16:07
		Re: virtual hosts support By: venus on Sat, 24 August 2002 18:03
		Re: virtual hosts support By: Ilia on Sat, 24 August 2002 18:42
		Re: virtual hosts support By: venus on Sun, 25 August 2002 11:00
		Re: virtual hosts support By: Ilia on Sun, 25 August 2002 16:01
		Re: virtual hosts support By: ruzam on Thu, 21 July 2005 22:51
		Re: virtual hosts support By: Ilia on Thu, 21 July 2005 22:58
		Re: virtual hosts support By: ruzam on Fri, 22 July 2005 01:25
		Re: virtual hosts support By: Ilia on Fri, 22 July 2005 02:00
		Re: virtual hosts support By: ruzam on Tue, 26 July 2005 20:06
		Re: virtual hosts support By: Ilia on Tue, 26 July 2005 20:16
		Re: virtual hosts support By: ruzam on Tue, 26 July 2005 20:41
		Re: virtual hosts support By: ruzam on Tue, 26 July 2005 21:14
		Re: virtual hosts support By: Ilia on Tue, 26 July 2005 21:44
		Re: virtual hosts support By: ruzam on Tue, 26 July 2005 22:10
		Re: virtual hosts support By: Ilia on Tue, 26 July 2005 22:18
		Re: virtual hosts support By: Ilia on Tue, 26 July 2005 22:35
		Re: virtual hosts support By: Anonymous on Wed, 27 July 2005 21:45
		Re: virtual hosts support By: ruzam on Wed, 27 July 2005 21:49
		Re: virtual hosts support By: Ilia on Wed, 27 July 2005 22:46
		Re: virtual hosts support By: ruzam on Mon, 10 October 2005 04:47
		Re: virtual hosts support By: Ilia on Mon, 10 October 2005 15:04
		Re: virtual hosts support By: ruzam on Mon, 10 October 2005 16:00
		Re: virtual hosts support By: ruzam on Mon, 10 October 2005 16:51
		Re: virtual hosts support By: Ilia on Tue, 11 October 2005 14:44
		Re: virtual hosts support By: ruzam on Tue, 11 October 2005 16:17
		Re: virtual hosts support By: ruzam on Tue, 11 October 2005 20:45
		Re: virtual hosts support By: Ilia on Tue, 11 October 2005 23:09
		Re: virtual hosts support By: Ilia on Tue, 11 October 2005 23:38
		Re: virtual hosts support By: ruzam on Wed, 12 October 2005 00:34
		Re: virtual hosts support By: Ilia on Wed, 12 October 2005 00:46
		Re: virtual hosts support By: ruzam on Wed, 12 October 2005 01:22
		Re: virtual hosts support By: ruzam on Wed, 12 October 2005 01:51
		Re: virtual hosts support By: ruzam on Wed, 12 October 2005 03:38
		Re: virtual hosts support By: Ilia on Wed, 12 October 2005 13:25
		Re: virtual hosts support By: ruzam on Wed, 12 October 2005 18:34
		Re: virtual hosts support By: Ilia on Wed, 12 October 2005 20:26
		Re: virtual hosts support By: ruzam on Wed, 12 October 2005 20:34
		Re: virtual hosts support By: Ilia on Wed, 12 October 2005 21:08
		Re: virtual hosts support By: ruzam on Thu, 13 October 2005 06:13
		Re: virtual hosts support By: Ilia on Thu, 13 October 2005 15:47
		Re: virtual hosts support By: ruzam on Tue, 11 October 2005 17:05
		Re: virtual hosts support By: Anonymous on Fri, 14 October 2005 07:15
		Re: virtual hosts support By: Ilia on Fri, 14 October 2005 13:57
		Re: virtual hosts support By: ruzam on Fri, 14 October 2005 16:10
		Re: virtual hosts support By: ruzam on Sat, 15 October 2005 04:06
		Re: virtual hosts support By: Ilia on Sat, 15 October 2005 17:34
		Re: virtual hosts support By: Ilia on Sat, 15 October 2005 18:39
		Re: virtual hosts support By: ruzam on Sun, 16 October 2005 15:56
		Re: virtual hosts support By: ruzam on Sun, 16 October 2005 16:23
		Re: virtual hosts support By: ruzam on Sun, 16 October 2005 16:29
		Re: virtual hosts support By: Ilia on Mon, 17 October 2005 14:39
		Re: virtual hosts support By: Ilia on Mon, 17 October 2005 14:43
		Re: virtual hosts support By: ruzam on Mon, 17 October 2005 17:02
		Re: virtual hosts support By: Ilia on Mon, 17 October 2005 20:03
		Re: virtual hosts support By: ruzam on Mon, 17 October 2005 23:18

Previous Topic:	dont show catagories if they are invisible
Next Topic:	default forum

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sun Nov 24 21:17:26 GMT 2024

Total time taken to generate the page: 0.04430 seconds