FUDforum: How To » PATH_INFO theme option

Home » FUDforum » How To » PATH_INFO theme option

Show: Today's Messages :: Polls :: Message Navigator

Re: PATH_INFO theme option [message #31951 is a reply to message #31943]

Fri, 26 May 2006 02:15

geekmug

Messages: 5
Registered: January 2006

Karma:

Junior Member

The spot I am refering to is users.inc.t@641:

	/* this should allow path_info & normal themes to work properly within 1 forum */
	if ($o2 & 32768 && !($u->theme_opt & 4)) {
		$o2 ^= 32768;
	}

This block of code masks out the PATH_INFO flag for the rest of the code. I checked against the CVS admin panel, there is no checkbox for this theme option. This seems to be a magic flag brought on by the theme being named both 'path_info' and having the '.path_info' file. I think this should be reduced to just having the '.path_info' file, as this would make the most sense (and not some checkbox a person has to check). theme.inc has several things to say on this.

theme.inc@40:fud_theme::add():

		if ($this->theme == 'path_info') {
			$this->theme_opt |= 4;
		}

theme.inc@72:fud_theme::sync():

		if ($this->theme == 'path_info' || @file_exists($GLOBALS['DATA_DIR'].'thm/'.$this->theme.'/.path_info')) {
			$this->theme_opt |= 4;
		}

I would prefer both of those be:

		if(@file_exists($GLOBALS['DATA_DIR'].'thm/'.$this->theme.'/.path_info')) {
			$this->theme_opt |= 4;
		}

Which would then use the '.path_info' as the magic switch.

Report message to a moderator

[Message index]

		PATH_INFO theme option By: geekmug on Thu, 25 May 2006 01:42
		Re: PATH_INFO theme option By: Ilia on Thu, 25 May 2006 23:35
		Re: PATH_INFO theme option By: geekmug on Fri, 26 May 2006 02:15
		Re: PATH_INFO theme option By: Ilia on Fri, 26 May 2006 14:16
		Re: PATH_INFO theme option By: geekmug on Fri, 26 May 2006 14:27

Previous Topic:	Most users online
Next Topic:	[Solved] category and header.tmpl

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Mon Sep 30 19:22:52 GMT 2024

Total time taken to generate the page: 0.03914 seconds