FUDforum: Bug Reports » SQL bug in default theme

Home » FUDforum Development » Bug Reports » SQL bug in default theme

Show: Today's Messages :: Polls :: Message Navigator

Re: SQL bug in default theme [message #34902 is a reply to message #34892]

Wed, 22 November 2006 16:44

jyoder

Messages: 5
Registered: November 2006
Location: Michigan, USA

Karma:

Junior Member

Ilia wrote on Wed, 22 November 2006 10:12

This bug was fixed in CVS earlier, the official patch can be found here:
http://cvs.prohost.org/c/index.cgi/FUDforum/chngview?cn=11611

That fix merely made the number of parenthesis match, the resulting SQL is still broken. Here's the error you get:

ERROR:  argument of OR must be type boolean, not type integer

Which is due to the WHERE clause:

WHERE (mo.id IS NOT NULL OR (COALESCE(g2.group_cache_opt, g1.group_cache_opt)) & 1)>0

This ties the

>0

to the entire WHERE clause and not just the result of the COALESCE as intended.

My patch results in the following WHERE clauses (depending on the options) :

WHERE  (mo.id IS NOT NULL OR (COALESCE(g2.group_cache_opt, g1.group_cache_opt) & 1)>0)

WHERE  ((g1.group_cache_opt & 1)>0)

Obviously the outer ()'s aren't required, but this was the least number of characters I could change to fix the statement.

EDIT: On further reflection, removing the outer parenthesis makes it a 2 character patch instead of 3 Smile

                        ((!$is_a || $cat_id) ?  ' WHERE ' : '') .
-                       ($is_a ? '' : (_uid ? ' (mo.id IS NOT NULL OR (COALESCE(g2.group_cache_opt, g1.group_cache_opt))' : ' (g1.group_cache_opt').' & 1)>0') .
+                       ($is_a ? '' : (_uid ? ' mo.id IS NOT NULL OR (COALESCE(g2.group_cache_opt, g1.group_cache_opt)' : ' (g1.group_cache_opt').' & 1)>0') .
                        ($cat_id ? ($is_a ? '' : ' AND ') . ' v.c IN('.implode(',', ($cf = $cidxc[$cat_id][5])).') ' : '').' ORDER BY v.id');

Thanks!

[Updated on: Wed, 22 November 2006 16:55]

Report message to a moderator

[Message index]

		SQL bug in default theme By: jyoder on Tue, 21 November 2006 15:49
		Re: SQL bug in default theme By: Ernesto on Tue, 21 November 2006 16:39
		Re: SQL bug in default theme By: jyoder on Tue, 21 November 2006 17:31
		Re: SQL bug in default theme By: Ilia on Wed, 22 November 2006 15:12
		Re: SQL bug in default theme By: jyoder on Wed, 22 November 2006 16:44
		Re: SQL bug in default theme By: Ilia on Thu, 23 November 2006 14:27
		Re: SQL bug in default theme By: jyoder on Fri, 01 December 2006 03:50
		Re: SQL bug in default theme By: Ilia on Fri, 01 December 2006 15:39
		Re: SQL bug in default theme By: jyoder on Fri, 01 December 2006 16:45
		Re: SQL bug in default theme By: hoanhnd on Wed, 06 December 2006 08:49
		Re: SQL bug in default theme By: hoanhnd on Wed, 06 December 2006 08:39

Previous Topic:	problems with CSS after changing document root for FUDforum
Next Topic:	Inbox - Sort by xxxxxxx

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Dec 05 02:43:20 GMT 2024

Total time taken to generate the page: 0.04320 seconds