FUDforum: Plugins and Code Hacks » GLOBALS.php and integration: suggested patch

Home » FUDforum Development » Plugins and Code Hacks » GLOBALS.php and integration: suggested patch

Show: Today's Messages :: Polls :: Message Navigator

GLOBALS.php and integration: suggested patch [message #166583]

Tue, 24 January 2012 02:52

NeXuS
Messages: 121
Registered: July 2010
Location: South Korea

Karma: 5

Senior Member
Contributing Core Developer

Hello,
I recently made the switch from PhpBB3 to FUDforum (bless an API that one can actually call that). Unfortunately I had a problem with integration that has already been brought up (fud_use() undefined and all that nonsense), but I think there is an easy solution to everyone's problems.

I patched glob.inc so that the change_global_settings() function looks for variables defined as $GLOBALS['var_name'] instead of just $var_name. The reason behind this is that including GLOBALS.php from a class (as required by integration with CodeIgniter) does not work properly as the variables are not explicitly declared as global.

I hope this helps

P.S. I just realized this is not the right forum, and I should have posted under the "Plugins and code hacks" one. Sorry.

EDIT: Corrected a sentence

Attachment: glob.inc.patch.zip
(Size: 0.65KB, Downloaded 1091 times)

[Updated on: Wed, 25 January 2012 07:46]

Report message to a moderator

Re: GLOBALS.php and integration: suggested patch [message #166611 is a reply to message #166583]

Sat, 28 January 2012 05:02

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

The patch looks good, but needs some work:

1. We also need to fix this line in change_global_settings (to add the $GLOBALS bit):
$p = strpos($settings, 'ADMIN_EMAIL');

2. We need some code in upgrade.php to change all setting to the new format.

Let me know if you need SVN commit access.

PS: The Lightbox plugin makes it almost impossible to download ZIP files! We will have to sort it out as well...

Report message to a moderator