FUDforum: FUDforum Installation Issues » path_info: tabs broken after upgrade

Home » FUDforum » FUDforum Installation Issues » path_info: tabs broken after upgrade (path_info url`s not set after upgrade to 2.8.0)

Show: Today's Messages :: Polls :: Message Navigator

path_info: tabs broken after upgrade [message #158723]

Sun, 15 March 2009 20:23

!alex

Messages: 23
Registered: February 2004
Location: germany

Karma: 0

Junior Member

After upgrading from 2.6.5 -> 2.7.7 -> 2.8.0 the links in the tabs don't work anymore for path_info based theme.

Instad of index.php/pdm/ (path_info url) index.php?t=pmsg is set as target, also for the other tabs.

I went through the templates etc. for a while but wasn't able to figure out where to change it, also compared tabs.inc.t with the version from 2.6.5 - no success Sad

For me also a set of rules for mod_rewrite that redirects default-url`s to url`s that work with path_info would be fine,
this could keep me (and others, having problems with path_info ur`s) from fixing it on every single place Wink

Best Regards,
Alex

[Updated on: Sun, 15 March 2009 20:25]

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158724 is a reply to message #158723]

Sun, 15 March 2009 20:41

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Hi Alex,

I'm also using the PATH_INFO theme and don't see any default URLs. Please check:

1) if "Use PATH_INFO style URLs" is set to true in the Admin Control Panel -> Global Configuration; and

2) if you are using the PATH_INFO theme in the Admin Control Panel -> Theme Manager.

Best regards.

Frank

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158725 is a reply to message #158723]

Sun, 15 March 2009 20:54

!alex

Messages: 23
Registered: February 2004
Location: germany

Karma: 0

Junior Member

Hi Frank,
well, both is set, but i wonder why only on the tabs the url`s are not set the way they should..

I also had a look at forum/src/tabs.inc.t where the url`s are set:

              foreach($tablist as $tab_name => $tab) {
                        $tab_url = '{ROOT}?t='.$tab.(s ? '&amp;S='.s : '');
                        if ($tab == 'referals') {
                                if (!($FUD_OPT_2 & 8192)) {
                                        continue;
                                }
                                $tab_url .= '&amp;id='._uid;
                        } else if ($tab == 'showposts') {
                                $tab_url .= '&amp;id='._uid;
                        }
                        $tabs .= $pg == $tab ? '{TEMPLATE: active_tab}' : '{TEMPLATE: inactive_tab}';
                }

                $tabs = '{TEMPLATE: tablist}';

For me this might be the place a clean path_info url should be written instead of _GET based url's ...

Alex

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158726 is a reply to message #158725]

Sun, 15 March 2009 21:12

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

OK, I understand the problem and can simulate it on my forum as well. Will start working on a patch tomorrow.

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158727 is a reply to message #158723]

Sun, 15 March 2009 21:23

!alex

Messages: 23
Registered: February 2004
Location: germany

Karma: 0

Junior Member

Thanks,
i`m currently working on a mod_rewrite set - will publish it here for those who don't want to patch ...

Alex

edit:
Not nice but works for the broken tabs ...
b.t.w.: translations _GET / path-info can be found in forum/src/users.inc.t Wink

RewriteCond %{QUERY_STRING} t=pmsg
RewriteRule  ^(.*)$ /forum/index.php/pdm/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=uc
RewriteRule  ^(.*)$ /forum/index.php/uc/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=register
RewriteRule  ^(.*)$ /forum/index.php/re/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=subscribed
RewriteRule  ^(.*)$ /forum/index.php/sl/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=buddy_list
RewriteRule  ^(.*)$ /forum/index.php/bl/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=ignore_list
RewriteRule  ^(.*)$ /forum/index.php/il/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=showposts&id=([0-9]+)
RewriteRule  ^(.*)$ /forum/index.php/sp/%1/$2? [R=301,L]

[Updated on: Sun, 15 March 2009 21:36]

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158728 is a reply to message #158723]

Sun, 15 March 2009 21:46

!alex

Messages: 23
Registered: February 2004
Location: germany

Karma: 0

Junior Member

There`s more problems on my install,
"Message Navigator" and "User Search" Forms is what i found, too ...
fixed it both with rewrite-rules for the beginning ...

Alex

[Updated on: Sun, 15 March 2009 22:02]

Report message to a moderator