| BUGs: LIMIT clause in postgresql [message #8039] |
Thu, 09 January 2003 03:16  |
laser
Messages: 9
Registered: January 2003
Karma: 0
|
Junior Member |
|
|
Seems no one use FUDforum with PostgreSQL, and less test in it.
but if you use it with current version of PostgreSQL (7.3.1),
you'll find there are lots of bugs:
first one is the the users table (in fuduser.tbl or something), the CREATE TABLE come with and
extra comma ',' at the end of last line, the consraint, causing installation on PostgreSQL failed.
second one is very big: in PostgreSQL 7.3.1, the "LIMIT #,#" clause are obsolete, you should use "LIMIT # OFFSET #", the later
is SQL standard compliant, but the formal is not. (I think it's
mysql specefic). There are many places with direct hard coded
LIMIT #,# and not using qry_limit() function, cost a few hours to check. 
finally, I want to ask how to change the code in install.php directly? those md5() check and LIMIT clause *did* annoying me
while I want do fix those bugs in install.php directly, and failed at last.
any comment?
|
|
|
|
|
|
| Re: BUGs: LIMIT clause in postgresql [message #8041 is a reply to message #8040] |
Thu, 09 January 2003 05:17  |
laser
Messages: 9
Registered: January 2003
Karma: 0
|
Junior Member |
|
|
sorry, my fault, I should make it more clearly.
Here is detail.
I'm not so familiar with FUDforum, (I'm using 2.3.6 now), so please forgive my ignorance about FUDforum's detail.
When I installed, there only one file need: install.php.
It's wonderfully easy for us to install and configure. Great job!
I think it's install.php who generate all those code need to run
the forum, that is, the install.php is like a self-zipped archinve, right? But it's plain text, except a few bytes at the header field. I can use emacs to edit it.
When I first meet those LIMIT #,# clause problem, I greped all occurence of LIMIT and change all those files --- lots of them,
you know, may be a few dozen files need to be change. And it's
tiresome work. So I want to change install.php directly, then all
the files it generate would be OK to use, it's much more easy.
and won't be so error prone. So I try to change install.php, fix those extra comma and those LIMIT clause directly, then I got checksum error while installing it. then I continue to revise it,
comment out those md5() check for I'm sure the file is correct,
but still get install error finally, take a look at index.php after install, it was obviously miss some bytes because those changes I made. so I give up, and reinstall using original install.php (make a little change: delete the extra ',' but added a blank space ' ' to complement the byte), install, and
change those files again.
So I want to know how to fix my problem at "root", and make my
life more easy, and maybe I can provide a patch for postgresql
too.
thanks.
|
|
|
|
| Re: BUGs: LIMIT clause in postgresql [message #8049 is a reply to message #8041] |
Thu, 09 January 2003 22:12 |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
|
|
I've taken your comments to heart and have applied several fixes to the PostgreSQL code in FUDforum. After the fixes I was able to install the forum on a server running PostgreSQL 7.3.1 without a problem and basic tests such as posting, replying and so on appear to be working.
Attached is an install script that has the applied fixes.
As for the archive inside the script it is generated from source files, if you look @ the CVS thread or read the docs you'll find out how you can generate the file itself.
FUDforum Core Developer
|
|
|
|
|
|
Calendar
Search
Help
Members
Register
Login
Home
]