FUDforum: Bug Reports » Consistency checking removes all forum dumps

Home » FUDforum Development » Bug Reports » Consistency checking removes all forum dumps

Show: Today's Messages :: Polls :: Message Navigator

Consistency checking removes all forum dumps [message #22526]

Sun, 06 February 2005 11:49

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Hi,

By default forum datadumps are written to the FUDdata/tmp directory. However, this directory gets cleaned-up when you run the consistency checker.

What makes this worst: if you re-import forum data, you are asked to run the consistency checker which will delete the datadump you've just imported. So, you cannot ever do it again!

Please consider writing datadump files to a different (default) directory. Something like FUDdata/backup would make more sense anyway.

Best regards.

Frank

Report message to a moderator

Re: Consistency checking removes all forum dumps [message #22534 is a reply to message #22526]

Sun, 06 February 2005 18:41

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

The idea is that after a backup is made you'd copy it to the backup machine or elsewhere. It is fairly pointless to store backups on the same machine as the data itself is located on.

FUDforum Core Developer

Report message to a moderator

Re: Consistency checking removes all forum dumps [message #22536 is a reply to message #22534]

Sun, 06 February 2005 19:17

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

That is a bad assumption - you should know better. Backups can ever go into a tmp directory!!!

Report message to a moderator

Re: Consistency checking removes all forum dumps [message #22538 is a reply to message #22536]

Sun, 06 February 2005 20:49

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Know better then what? Backup is intended as a current snapshot of the forum that you should move elsewhere. If you keep it tmp/ directory, well then be sure to move it before consistency checker runs.

FUDforum Core Developer

Report message to a moderator

Re: Consistency checking removes all forum dumps [message #22545 is a reply to message #22538]

Mon, 07 February 2005 00:01

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Hi,

I took a backup with the intention to restore it within minutes if the conversion script chokes on me again. There was no need to copy it to a remote system.

Also, the files may be removed before you get a chance to copy it.

Can you at least skip files newer than X hours, or warn people about what you will do with their backups when they use the default backup destination?

Best regards.

Frank

Report message to a moderator

Re: Consistency checking removes all forum dumps [message #22571 is a reply to message #22545]

Mon, 07 February 2005 15:16

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Doing time check would be too slow (1 stat() per file), so I added a check that sees if the file begins with the forum's standard backup file prefix. If it does it is skipped and not removed.

here is the patch:

http://cvs.prohost.org/c/index.cgi/FUDforum/chngview?cn=3292

FUDforum Core Developer

Report message to a moderator

Re: Consistency checking removes all forum dumps [message #22577 is a reply to message #22571]

Mon, 07 February 2005 16:25

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Much appreciated!!!

Regards.

Frank

Report message to a moderator

Previous Topic:	Deleting attachment from within a message fails
Next Topic:	Admin login problem

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Nov 29 21:38:39 GMT 2024

Total time taken to generate the page: 0.02488 seconds