A few suggestions [message #33709] |
Fri, 15 September 2006 22:30 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
- I noticed that the information about the last visit displayed on the index page gets updated on every reload of the index page. I think it should display the time when I finished my last visit.
- When a login attempt to the Admin Control Panel fails a corresping log entry in the Action log viewer is created. I think this log entry should contain the used login details. And I think that the message "User is no longer in system" is a bit confusing if the message was caused by an anon user.
|
|
|
Re: A few suggestions [message #33739 is a reply to message #33709] |
Mon, 18 September 2006 16:45 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
JanRei wrote on Fri, 15 September 2006 18:30 | [list type=1]
[*] I noticed that the information about the last visit displayed on the index page gets updated on every reload of the index page. I think it should display the time when I finished my last visit.
|
Intentional, there is no way to tell what was your "last" visit. I suppose code can be hacked to use some sort of pre-set time differential, Ex 2-3 hours.
Quote: |
[*] When a login attempt to the Admin Control Panel fails a corresping log entry in the Action log viewer is created. I think this log entry should contain the used login details. And I think that the message "User is no longer in system" is a bit confusing if the message was caused by an anon user.
|
I've added tracking of entered login/password. The other change would be tricky as it would require a special hack specifically for failed logins.
FUDforum Core Developer
|
|
|
|
Re: A few suggestions [message #33746 is a reply to message #33743] |
Mon, 18 September 2006 17:25 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
JanRei wrote on Mon, 18 September 2006 13:12 |
Ilia wrote on Mon, 18 September 2006 18:45 | Intentional, there is no way to tell what was your "last" visit. I suppose code can be hacked to use some sort of pre-set time differential, Ex 2-3 hours.
|
I think that my session will be extended on every action I take in the forum? In this case you could say that my last vistit was when my session expired and the forum had to re-login me.
|
The shown time is of "last visit" not last login. And login in FUDforum can last for month or even years given long term cookie age settings.
Quote: |
Quote: | I've added tracking of entered login/password. The other change would be tricky as it would require a special hack specifically for failed logins.
|
Wouldn't it be enough to check whether the user id is 0? In this case you can show "Unknown user" or something like that. According to my observations former members have got an id that is not 0.
|
There is also account removal to consider.
FUDforum Core Developer
|
|
|
Re: A few suggestions [message #33749 is a reply to message #33746] |
Mon, 18 September 2006 19:17 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
Ilia wrote on Mon, 18 September 2006 19:25 |
The shown time is of "last visit" not last login. And login in FUDforum can last for month or even years given long term cookie age settings.
|
Well, I thought the procedure could be like this:
- The user visits the user.
- The forum checks the session of the forum.
- User is still in the same session as he was on the request before and no cookie has to be used: In this case the "last visit" will not be updated.
- The forum has to create a new session for the user or the forum has to use the cookie: In this case the "last visit" is either the time of the end of the last session or (if this can't be determined) the time of the last action of the user.
Ilia |
JanRei |
Wouldn't it be enough to check whether the user id is 0? In this case you can show "Unknown user" or something like that. According to my observations former members have got an id that is not 0.
|
There is also account removal to consider.
|
I did consider account removal. When the admin deletes an user this doesn't affect the action list. I still think that checking the user_id field in the fud26_action_log table is the easiest way.
[Updated on: Mon, 18 September 2006 19:24] Report message to a moderator
|
|
|
Re: A few suggestions [message #33755 is a reply to message #33749] |
Tue, 19 September 2006 14:28 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
The forum creates a new session for the user only upon login, which once again means you are changing last visit into last login (something already tracked via another field in the users table).
As far as the action_log user_id field, that would only be populated for logged-in users already having an id field.
FUDforum Core Developer
|
|
|
|
Re: A few suggestions [message #33789 is a reply to message #33760] |
Thu, 21 September 2006 22:02 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
There is no user id when someone is trying to login...
FUDforum Core Developer
|
|
|
|
|
|
|
Re: A few suggestions [message #33869 is a reply to message #33865] |
Sun, 24 September 2006 17:25 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
The login of the deleted user is in the "action" the login of the admin it shown to indicate who performed the account deletion.
FUDforum Core Developer
|
|
|
|
|
|
Re: A few suggestions [message #33983 is a reply to message #33980] |
Sat, 30 September 2006 17:25 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
The question in this case what to show? I suppose on topic view that's easy, just show messages in that forum, but what about the forum's front page or the topic list view.
FUDforum Core Developer
|
|
|
|
Re: A few suggestions [message #34015 is a reply to message #34009] |
Sun, 01 October 2006 19:18 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
All the messages on the forum? Do you realize how impractical (slow, large), not to mention useless that RSS feed would be.
FUDforum Core Developer
|
|
|
|
|
|
Re: A few suggestions [message #34051 is a reply to message #34028] |
Mon, 02 October 2006 18:07 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
RSS reference links were introduced to the pages that contains RSS links.
FUDforum Core Developer
|
|
|
|
Re: A few suggestions [message #34071 is a reply to message #34070] |
Tue, 03 October 2006 19:55 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
I don't see a compelling reason for syndicating the forum's user list.
FUDforum Core Developer
|
|
|
|
|
Re: A few suggestions [message #34116 is a reply to message #34114] |
Fri, 06 October 2006 14:58 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
Can you explain better, I am not entirely certain what you mean.
FUDforum Core Developer
|
|
|
Re: A few suggestions [message #34122 is a reply to message #33709] |
Fri, 06 October 2006 15:08 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
As far as I know it is possible to specify the next and the previous page for a page in the html header.
I think this could be used for topic view or topic listing (and maybe also other pages), the advantage of this should be that you can use Opera's mouse gestures for going to next/previous page.
[Updated on: Fri, 06 October 2006 15:08] Report message to a moderator
|
|
|
Re: A few suggestions [message #34124 is a reply to message #34122] |
Fri, 06 October 2006 15:10 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
Do you know of other browsers support it? It seems silly to add a feature for a browser with miniscule market share while at the same time making everyone download extra text they don't really need.
FUDforum Core Developer
|
|
|
Re: A few suggestions [message #34254 is a reply to message #33709] |
Mon, 16 October 2006 12:31 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
No, I don't know any other browser that support. And I have to agree with you, if Opera is the only browser supporting it, it's better keep it as it is.
|
|
|