FUDforum: Bug Reports » NNTP Sync minor quirks

Home » FUDforum Development » Bug Reports » NNTP Sync minor quirks

Show: Today's Messages :: Polls :: Message Navigator

NNTP Sync minor quirks [message #159768]

Mon, 22 June 2009 01:46

jcarter

Messages: 25
Registered: August 2006

Karma:

Junior Member

I recently upgraded to the latest version and have found several minor issues:

Version: 2.8.1

File: FUDForumData/include/nntp.inc

Around line 425:

if ( !strlen($msg_post->subject) ) {

The problem is that $msg_post->subject can be null which halts the script. I replaced it with:

if ( ($msg_post->subject == null) || !strlen($msg_post->subject) ) {

---------------------------------
Around line 455:

iconv_mime_encode("Subject:", $subject,

The problem is that the iconv_mime_encode function expects a keyword, and adds the colon, resulting in double colons and mangled subject thread titles. I changed it to :

iconv_mime_encode("Subject", $subject,

------------------------------------------

I posted these to {patches}.

Report message to a moderator

[Message index]

		NNTP Sync minor quirks By: jcarter on Mon, 22 June 2009 01:46
		Re: NNTP Sync minor quirks By: naudefj on Wed, 24 June 2009 13:11

Previous Topic:	Attachments in newsgroups aren't decoded
Next Topic:	why i cannot add a new Category of Forum

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Nov 30 01:50:32 GMT 2024

Total time taken to generate the page: 0.04413 seconds