Home »
FUDforum Development »
Bug Reports »
Some small issues (XHTML header, undefined variable, check of confirmation password)
Some small issues [message #162151] |
Fri, 26 March 2010 23:01 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma:
|
Senior Member Contributing Core Developer Translator |
|
|
- The language referenced in the XHTML header is not correct in my installation. I have chosen to install the forum in German, but directly after install I get this: <html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="en" xml:lang="en">
And after rebuilding of the theme it's empty: <html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="" xml:lang="">
I do not understand the issue completely yet, but it seems related to use of pspell_lang for this. My PHP installation does not have pspell support enabled. Maybe we could use the language code instead?
- I get a notice that the variable $login in include\theme\default\adm_acc.inc is not defined. The login name would be available in $GLOBALS['r']->login.
- The check of the confirmation password does not work correctly for me. As far as I know $('#foobar') looks for the element with id "foobar", but the input element has no id at the moment. So it should work if we add a corresponding id. Or alternatively the JavaScript can be modified like this:
- if ($(password2).attr("value") != $('#'+ password1).attr('value')) {
+ if ($(password2).attr("value") != $('[name='+password1+']').attr('value')) {
|
|
|
Goto Forum:
Current Time: Thu Nov 28 16:17:39 GMT 2024
Total time taken to generate the page: 4.01346 seconds